[seq2seq] fix logger format for non-main process#9911
Merged
Conversation
Collaborator
|
@LysandreJik knows better for the centralized logging system so I'll defer to him. |
LysandreJik
approved these changes
Feb 1, 2021
Member
LysandreJik
left a comment
There was a problem hiding this comment.
Indeed, good catch! All processes should share the handler/formatting options, even if they have different verbosity.
Thanks @stas00!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in
finetune_trainer.pynon-main process doesn't have any formatting at all, so we end up with:as you can see the 2nd process in DDP misses formatting in logger.
this PR fixes it.
I looked in the take-over version
run_seq2seq.pyif it needed to be fixed too and it doesn't have these function calls, not sure why. They appear to be needed, unless they get called elsewhere.@sgugger, @patil-suraj