Skip to content

Add XLA test#9848

Merged
jplu merged 1 commit into
huggingface:masterfrom
jplu:tf-xla-test
Jan 29, 2021
Merged

Add XLA test#9848
jplu merged 1 commit into
huggingface:masterfrom
jplu:tf-xla-test

Conversation

@jplu
Copy link
Copy Markdown
Contributor

@jplu jplu commented Jan 27, 2021

What does this PR do?

In the same spirit than for the mixed precision test, this PR adds one for XLA compliancy.

Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, LGTM!

@LysandreJik
Copy link
Copy Markdown
Member

Out of curiosity, how long are those tests for the models that have them?

@jplu
Copy link
Copy Markdown
Contributor Author

jplu commented Jan 27, 2021

few milliseconds, XLA is really fast :)

Copy link
Copy Markdown
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this in the roadmap!

@jplu jplu merged commit fdcde14 into huggingface:master Jan 29, 2021
@jplu jplu deleted the tf-xla-test branch January 29, 2021 10:25
Qbiwan pushed a commit to Qbiwan/transformers that referenced this pull request Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants