Fix label datatype in TF Trainer #9616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sgugger
reviewed
Jan 15, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
This looks okay to me, but it looks increasingly clearer that we should have tests of the TFTrainer otherwise we are doing more harm than good by merging those kinds of PRs.
Member
|
I agree with Sylvain that while this is not tested, it's hard to recommend using it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the case where
labelscan be either adictor atf.Tensorwhen doing gradient accumulation.