Ignore lm_head decoder bias warning #9615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Is it normal that this bias is missing? |
This reverts commit f25177a.
Member
Author
|
By answering your question I realized this could be upstreamed directly in the RoBERTa model, which I just did. You can take a look at my answer this morning to a similar question: #6193 (comment). XLM-R is an alias of the RoBERTa model, hence why they both need this. |
sgugger
approved these changes
Jan 15, 2021
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Yes making the changes in the source class is more efficient (and better).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the warning that's currently happening when importing
xlm-roberta-basewith any of the XLM-R models.Closes #9579