Skip to content

Fix utils on Windows #9368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgugger merged 1 commit into from
Jan 4, 2021
Merged

Fix utils on Windows #9368

sgugger merged 1 commit into from
Jan 4, 2021

Conversation

@jplu
Copy link
Contributor

@jplu jplu commented Dec 31, 2020

What does this PR do?

This PR fixes check_repo for Windows execution.

@jplu jplu requested review from sgugger and stas00 December 31, 2020 10:51
stas00
stas00 reviewed Dec 31, 2020
View reviewed changes
Copy link
Contributor

@stas00 stas00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you, @jplu

Perhaps we should compile notes somewhere so that our tools are cross-platform in first place.

sgugger
sgugger approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@sgugger sgugger merged commit de29ff9 into huggingface:master Jan 4, 2021
@jplu jplu deleted the fix-windows branch January 4, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@stas00 stas00 stas00 left review comments

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jplu @stas00 @sgugger