Skip to content

[finetune trainer] better logging and help #9203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stas00 merged 1 commit into from
Dec 20, 2020
Merged

[finetune trainer] better logging and help #9203

stas00 merged 1 commit into from
Dec 20, 2020

Conversation

@stas00
Copy link
Contributor

@stas00 stas00 commented Dec 19, 2020

As a follow up to this thread this PR:

  • documents that --val_max_target_length is also used during generate
  • disambiguates use_task_specific_params logger so that it's clear that it dumps just the initial params and that those could be overridden by user's cl args

@sgugger

sgugger
sgugger approved these changes Dec 20, 2020
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stas00 stas00 merged commit f38c4ad into huggingface:master Dec 20, 2020
@stas00 stas00 deleted the maxlen branch December 20, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stas00 @sgugger