Pass kwargs to Pipeline's tokenizer call #9143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When calling a Pipeline, the
kwargsargument is not passed to the tokenizer (it is actually not used at all).I think the intended behavior is to pass it (as the base tokenizer's
__call__()method already supportskwargs), and that's what this PR does.[Related to #8180]
The call order is:
Before submitting
to it if that's the case.
documentation guidelines, and here are tips on formatting docstrings.
Who can review?
@sgugger @LysandreJik