keys_to_ignore_at_inference -> output_keys_to_ignore_at_inference #8857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickvonplaten
approved these changes
Nov 30, 2020
LysandreJik
reviewed
Dec 1, 2020
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Unfortunately, this was present in the v4.0.0, so changing this would be a breaking change, as it's a public attribute.
The simplest would be to have a property on configuration utils returning output_keys_to_ignore_at_inference when prompted with keys_to_ignore_at_inference, along with a deprecation warning.
Collaborator
Author
|
Not sure this is really worth the hassle then. |
Contributor
Agree, let's leave it. It's just a personal cosmetic change, so not worth the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@patrickvonplaten mentioned in #8633 he was not happy with a name I picked, so I changed it.