Skip to content

Conversation

@sgugger
Copy link
Collaborator

@sgugger sgugger commented Nov 23, 2020

What does this PR do?

In Datasets, the default cache path ends up in ~/.cache/huggingface/datasets, controlled by the environment variable HF_HOME. This PR uses the same env variable for the default cache path.
To avoid breaking changes:

  • it still honors old environment variable names, if set
  • if none is set, it moves the cache folder from the old location to the new one with a warning.

@sgugger sgugger requested a review from LysandreJik November 23, 2020 18:36
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgugger sgugger merged commit 9000242 into master Nov 23, 2020
@sgugger sgugger deleted the cache_path branch November 23, 2020 18:56
LysandreJik added a commit that referenced this pull request Nov 23, 2020
* Change default cache path

* Document changes

* Apply suggestions from code review

Co-authored-by: Lysandre Debut <[email protected]>

Co-authored-by: Lysandre Debut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants