Skip to content

Conversation

@gijswijnholds
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #6480 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6480      +/-   ##
==========================================
- Coverage   80.03%   79.96%   -0.07%     
==========================================
  Files         156      156              
  Lines       28058    28058              
==========================================
- Hits        22456    22437      -19     
- Misses       5602     5621      +19     
Impacted Files Coverage Δ
src/transformers/modeling_tf_bert.py 69.06% <0.00%> (-29.32%) ⬇️
src/transformers/tokenization_t5.py 71.83% <0.00%> (-23.95%) ⬇️
src/transformers/modeling_tf_gpt2.py 71.84% <0.00%> (-23.17%) ⬇️
src/transformers/modeling_xlnet.py 60.53% <0.00%> (-22.78%) ⬇️
src/transformers/modeling_bert.py 88.26% <0.00%> (-0.17%) ⬇️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+0.25%) ⬆️
src/transformers/configuration_utils.py 96.59% <0.00%> (+0.68%) ⬆️
src/transformers/modeling_tf_utils.py 87.29% <0.00%> (+0.97%) ⬆️
src/transformers/modeling_openai.py 82.25% <0.00%> (+1.29%) ⬆️
src/transformers/tokenization_auto.py 97.77% <0.00%> (+2.22%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a8c168...ab9eb7f. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @sgugger

@LysandreJik LysandreJik merged commit b5ba758 into huggingface:master Aug 14, 2020
sgugger added a commit that referenced this pull request Aug 14, 2020
* Generation doc

* MBartForConditionalGeneration (#6441)

* add MBartForConditionalGeneration

* style

* rebase and fixes

* add mbart test in TEST_FILES_WITH_NO_COMMON_TESTS

* fix docs

* don't ignore mbart

* doc

* fix mbart fairseq link

* put mbart before bart

* apply doc suggestions

* Use hash to clean the test dirs (#6475)

* Use hash to clean the test dirs

* Use hash to clean the test dirs

* Use hash to clean the test dirs

* fix

* [EncoderDecoder] Add Cross Attention for GPT2 (#6415)

* add cross attention layers for gpt2

* make gpt2 cross attention work

* finish bert2gpt2

* add explicit comments

* remove attention mask since not yet supported

* revert attn mask in pipeline

* Update src/transformers/modeling_gpt2.py

Co-authored-by: Sylvain Gugger <[email protected]>

* Update src/transformers/modeling_encoder_decoder.py

Co-authored-by: Sylvain Gugger <[email protected]>

Co-authored-by: Sylvain Gugger <[email protected]>

* Sort unique_no_split_tokens to make it deterministic (#6461)

* change unique_no_split_tokens's type to set

* use sorted list instead of set

* style

* Import accuracy_score (#6480)

* Apply suggestions from code review

Co-authored-by: Lysandre Debut <[email protected]>

* Address comments

* Styling

* Generation doc

* Apply suggestions from code review

Co-authored-by: Lysandre Debut <[email protected]>

* Address comments

* Styling

Co-authored-by: Suraj Patil <[email protected]>
Co-authored-by: Kevin Canwen Xu <[email protected]>
Co-authored-by: Patrick von Platen <[email protected]>
Co-authored-by: Quentin Lhoest <[email protected]>
Co-authored-by: gijswijnholds <[email protected]>
Co-authored-by: Lysandre Debut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants