Skip to content

Fix zamba2 rotary embedding call when use_mem_rope is False #44551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydshieh merged 2 commits into from
Mar 10, 2026
Merged

Fix zamba2 rotary embedding call when use_mem_rope is False #44551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebb66ef
only call rotary_emb when config.use_mem_rope is True
echarlaix Mar 9, 2026
20cae84
add fix in modular
echarlaix Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/transformers/models/zamba2/modeling_zamba2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1337,7 +1337,12 @@ def forward(
past_key_values=past_key_values,
position_ids=position_ids,
)
position_embeddings = self.rotary_emb(hidden_states, position_ids=position_ids)

# create position embeddings to be shared across the decoder layers
if self.config.use_mem_rope:
position_embeddings = self.rotary_emb(hidden_states, position_ids=position_ids)
else:
position_embeddings = None

all_hidden_states = () if output_hidden_states else None
all_self_attns = () if output_attentions else None
Expand Down
7 changes: 6 additions & 1 deletion src/transformers/models/zamba2/modular_zamba2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,12 @@ def forward(
past_key_values=past_key_values,
position_ids=position_ids,
)
position_embeddings = self.rotary_emb(hidden_states, position_ids=position_ids)

# create position embeddings to be shared across the decoder layers
if self.config.use_mem_rope:
position_embeddings = self.rotary_emb(hidden_states, position_ids=position_ids)
else:
position_embeddings = None

all_hidden_states = () if output_hidden_states else None
all_self_attns = () if output_attentions else None
Expand Down