Fixed failing BioGPT batch generation test
#43128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasqu
approved these changes
Jan 6, 2026
Contributor
vasqu
left a comment
vasqu
left a comment
There was a problem hiding this comment.
LGTM, can you add a small comment as to why we use 20 (i.e. it's the default value in the generation config when calling .generate)
Contributor
|
run-slow: biogpt |
Contributor
|
This comment contains models: ["models/biogpt"] |
Contributor
CI Results✅ No failing test specific to this PR 🎉 ! |
Sai-Suraj-27
force-pushed
the
fix_biogpt_test1
branch
from
67f13fd to
8a01008
Compare
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: biogpt |
Contributor
|
Thx, merging now |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SangbumChoi
pushed a commit
to SangbumChoi/transformers
that referenced
this pull request
Jan 23, 2026
* Fixed failing BioGPT batch generation test * Fixed failing BioGPT batch generation test * Comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes this failing BioGPT-batch generation test. From this PR Generation Config defaults are now None
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@Rocketknight1 @zucchini-nlp