-
Notifications
You must be signed in to change notification settings - Fork 31.1k
Fix torch+deepspeed docker file
#41985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb9fdf7 to
bf26a92
Compare
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
change it to draft as there are more things to fix In the deepspeed docker, we also have
|
3862fb4 to
919253a
Compare
| name: "Latest PyTorch + DeepSpeed" | ||
| runs-on: | ||
| group: aws-g4dn-2xlarge-cache | ||
| group: aws-general-8-plus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are not using T4 runners anymore. Since the CPU runners work now for building this image, let's use it.
SunMarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a nit
* fix * delete --------- Co-authored-by: ydshieh <[email protected]>
What does this PR do?
Similar to #41978 and #41975, but with extra issue of
--global-option=. All issues are caused by the new pip version25.3.Verified the docker file could be built and the
deepspeedCI job could run.