Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Nov 3, 2025

What does this PR do?

Similar to #41978 and #41975, but with extra issue of --global-option=. All issues are caused by the new pip version 25.3.

Verified the docker file could be built and the deepspeed CI job could run.

@ydshieh ydshieh force-pushed the run_slow_v2_backup branch from eb9fdf7 to bf26a92 Compare November 3, 2025 08:25
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh ydshieh requested a review from SunMarc November 3, 2025 08:39
@ydshieh
Copy link
Collaborator Author

ydshieh commented Nov 3, 2025

change it to draft as there are more things to fix

In the deepspeed docker, we also have torchcodec

RUN python3 -m pip uninstall -y torch torchvision torchaudio && python3 -m pip install --no-cache-dir -U torch==$PYTORCH torchvision torchaudio torchcodec --extra-index-url https://download.pytorch.org/whl/$CUDA

@ydshieh ydshieh marked this pull request as draft November 3, 2025 14:32
@ydshieh ydshieh removed the request for review from SunMarc November 3, 2025 14:32
@ydshieh ydshieh force-pushed the run_slow_v2_backup branch from 3862fb4 to 919253a Compare November 4, 2025 06:39
@ydshieh ydshieh marked this pull request as ready for review November 4, 2025 06:40
@ydshieh ydshieh requested a review from SunMarc November 4, 2025 06:40
name: "Latest PyTorch + DeepSpeed"
runs-on:
group: aws-g4dn-2xlarge-cache
group: aws-general-8-plus
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are not using T4 runners anymore. Since the CPU runners work now for building this image, let's use it.

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a nit

@ydshieh ydshieh enabled auto-merge (squash) November 4, 2025 10:33
@ydshieh ydshieh merged commit 6d4450e into main Nov 4, 2025
15 checks passed
@ydshieh ydshieh deleted the run_slow_v2_backup branch November 4, 2025 10:41
yonigozlan pushed a commit to yonigozlan/transformers that referenced this pull request Nov 7, 2025
* fix

* delete

---------

Co-authored-by: ydshieh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants