Skip to content

Conversation

@RyanMullins
Copy link
Contributor

What does this PR do?

Fixes #41964

  • Sets total=False on RopeParameters
  • Applies Required to the relevant properties of RopeParameters
  • More coming soon...

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Rocketknight1
Copy link
Member

LGTM but cc @zucchini-nlp @ArthurZucker!

@RyanMullins RyanMullins force-pushed the rope-type-hints branch 2 times, most recently from ddcd9e9 to cbb3751 Compare November 4, 2025 20:04
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: gemma3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve typing support and flexibility for RopeParameters

2 participants