Skip to content

Conversation

@Pranavi125
Copy link

This PR adds the missing SAFE_WEIGHTS_INDEX_NAME constant to the all list in constants.py.

Why:
Without this, the constant isn’t exported when using
from transformers.utils.constants import *.

Impact:

  • Keeps the constants module consistent.
  • No functional changes or breaking impact.

Copy link
Contributor

@vasqu vasqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These constants are used internally only, so I'm not sure why we'd want to include them here

Is there any issue or example you have? SAFE_WEIGHTS_INDEX_NAME doesn't even exist in the file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes here are unrelated, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants