Skip to content

Conversation

@yao-matrix
Copy link
Contributor

@yao-matrix yao-matrix commented Oct 6, 2025

covered modeling:

  • cohere2_vesion
  • ernie4_5
  • internvl
  • llava
  • llava_next
  • phi
  • qwen2.5_omni
  • whisper
  • xglm

@SunMarc @ydshieh , pls help review, thx very much.

@yao-matrix yao-matrix marked this pull request as draft October 6, 2025 18:16
@yao-matrix yao-matrix marked this pull request as ready for review October 6, 2025 21:20
@github-actions github-actions bot requested a review from ydshieh October 6, 2025 21:21
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yao-matrix ! 3 nit comments 🙏

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 7, 2025

Also FYI: I merged a PR #40727, and we can run tests like

PATCH_TESTING_METHODS_TO_COLLECT_OUTPUTS=yes HF_HOME=/mnt/cache HF_HUB_READ_TOKEN=hf_XXX RUN_SLOW=1 python3 -m pytest -v ....

It will produce an output file named captured_info.txt where contains the output values, pretty formatted.

The main advantage is that: if a test has several assert statements and fails at the first one, it won't stop but continue.

Hope you find it useful in the future.

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 7, 2025

Ping me once the nit comments are addressed , thanks.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yao-matrix
Copy link
Contributor Author

@ydshieh , done, pls help review again, thx very much.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: cohere2_vision, ernie4_5, internvl, llava, llava_next_video, phi3, qwen2_5_omni, qwen3, whisper, xglm

Copy link
Member

@SunMarc SunMarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SunMarc SunMarc enabled auto-merge (squash) October 8, 2025 10:06
@SunMarc SunMarc merged commit b13ee63 into huggingface:main Oct 8, 2025
25 checks passed
@yao-matrix yao-matrix deleted the issue-558 branch October 8, 2025 15:01
AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
…#41386)

* enable new model uts to xpu and fix some failures on xpu

Signed-off-by: Yao, Matrix <[email protected]>

* add more

Signed-off-by: Yao, Matrix <[email protected]>

* fix style

Signed-off-by: Yao, Matrix <[email protected]>

* Update test_modeling_internvl.py

* Update test_modeling_llava.py

* Update test_modeling_qwen2_5_omni.py

* Update test_modeling_llava_next_video.py

* Update test_modeling_qwen3.py

* Update test_modeling_whisper.py

* Update test_modeling_whisper.py

* Update test_modeling_llava.py

* Update test_modeling_llava.py

* Update test_modeling_qwen2_5_omni.py

* fix style

Signed-off-by: Yao, Matrix <[email protected]>

---------

Signed-off-by: Yao, Matrix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants