-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Add Type Hints to modeling_utils.py Closes #3911 #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
julien-c
merged 10 commits into
huggingface:master
from
bglearning:add-type-hints-to-modeling-utils
May 22, 2020
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
25c3dac
Add Type Hints to modeling_utils.py Closes #3911
179270c
Reformat according to `black` and `isort`
c394156
Use typing.Iterable instead of Sequence
6230800
Parameterize Iterable by its generic type
37942ca
Use typing.Optional when None is the default value
8fb3571
Merge branch 'master' into add-type-hints-to-modeling-utils
99848e8
Adhere to style guideline
a67d3a1
Update src/transformers/modeling_utils.py
julien-c 599ecbc
Update src/transformers/modeling_utils.py
julien-c 64b20c7
Merge branch 'master' into add-type-hints-to-modeling-utils
julien-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this not an
nn.Layeror even ann.Embedding?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through some tests, looks like it's expected to be either
nn.EmbeddingorAdaptiveEmbedding(frommodeling_transfo_xl.py). The docstring hasnn.Module(as "A module mapping vocabulary to hidden states"). Maybe it is so to have it be general? Not sure.