Skip to content

[peft] Given that self.active_adapter is deprecated, avoid using it #34804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[peft] Given that self.active_adapter is deprecated, avoid using it #34804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da88552
Given that self.active_adapter is deprecated, avoid using it
tomaarsen Nov 19, 2024
a2eca2b
Remove misleading comment - `self.active_adapter` is not used (and de…
tomaarsen Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/integrations/peft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ def enable_adapters(self) -> None:
If you are not familiar with adapters and PEFT methods, we invite you to read more about them on the PEFT
official documentation: https://huggingface.co/docs/peft

Enable adapters that are attached to the model. The model will use `self.active_adapter()`
Enable adapters that are attached to the model.
"""
check_peft_version(min_version=MIN_PEFT_VERSION)

Expand Down Expand Up @@ -457,7 +457,7 @@ def get_adapter_state_dict(self, adapter_name: Optional[str] = None) -> dict:
from peft import get_peft_model_state_dict

if adapter_name is None:
adapter_name = self.active_adapter()
adapter_name = self.active_adapters()[0]

adapter_state_dict = get_peft_model_state_dict(self, adapter_name=adapter_name)
return adapter_state_dict
Expand Down
Loading