Skip to content

Conversation

@andimarafioti
Copy link
Member

@andimarafioti andimarafioti commented Aug 16, 2024

What does this PR do?

Fixes #32288

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Models:

@andimarafioti andimarafioti mentioned this pull request Aug 16, 2024
5 tasks
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! multi-gpu runner finally ran and all passing so we're good to merge :)

@amyeroberts
Copy link
Contributor

@andimarafioti Do you have permission to merge in transformers? If not I can merge for you

@andimarafioti andimarafioti merged commit 18199b3 into huggingface:main Aug 22, 2024
@andimarafioti andimarafioti deleted the idefics2-test-fix branch November 21, 2024 13:49
BernardZach pushed a commit to BernardZach/transformers that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IDEFICS2 integration test hits OOM on CI

3 participants