Fix imports #25869
Merged
Fix imports #25869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Aug 30, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for the rapid investigation and fix!
younesbelkada
approved these changes
Aug 30, 2023
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
🔥 🔥
Thanks!
Too bad we did not ran doctests before merging that PR !
Collaborator
Author
|
@younesbelkada No, it's not about doctest - it's the usual |
|
The documentation is not available anymore as the PR was closed or merged. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
fix Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
So far test fetcher fails to fetching and all tests are collected. This PR fix a few import issues introduced in #25599, so we won't have all tests being collected and run.