Skip to content

[PEFT] Fix peft version #25710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
younesbelkada merged 3 commits into from
Aug 24, 2023
Merged

[PEFT] Fix peft version #25710

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e05f6ba
fix peft version
younesbelkada Aug 24, 2023
2759f7b
address comments
younesbelkada Aug 24, 2023
38bcb08
adapt suggestion
younesbelkada Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/transformers/utils/peft_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def check_peft_version(min_version: str) -> None:
if not is_peft_available():
raise ValueError("PEFT is not installed. Please install it with `pip install peft`")

is_peft_version_compatible = version.parse(importlib.metadata.version("peft")) <= version.parse(min_version)
is_peft_version_compatible = version.parse(importlib.metadata.version("peft")) > version.parse(min_version)
Copy link
Collaborator

@ydshieh ydshieh Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the min_version should be compatible. Using > min_version looks strange. We can min_version to use >= if necessary.


if not is_peft_version_compatible:
raise ValueError(
Expand Down