Skip to content

Remove utils/documentation_tests.txt #25680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydshieh merged 7 commits into from
Aug 23, 2023
Merged

Remove utils/documentation_tests.txt #25680

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e54cad
fix
ydshieh Aug 23, 2023
d1bb631
fix
ydshieh Aug 23, 2023
0e5b965
fix
ydshieh Aug 23, 2023
ea172ff
fix
ydshieh Aug 23, 2023
7825024
fix
ydshieh Aug 23, 2023
4a26095
fix
ydshieh Aug 23, 2023
7ebe6ac
Apply suggestions from code review
ydshieh Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/doctests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,13 @@ jobs:
- name: Show installed libraries and their versions
run: pip freeze

- name: Get doctest files
run: |
$(python3 -c 'from utils.tests_fetcher import get_all_doctest_files; to_test = get_all_doctest_files(); to_test = " ".join(to_test); fp = open("doc_tests.txt", "w"); fp.write(to_test); fp.close()')

- name: Run doctests
run: |
python3 -m pytest -v --make-reports doc_tests_gpu --doctest-modules $(cat utils/documentation_tests.txt) -sv --doctest-continue-on-failure --doctest-glob="*.md"
python3 -m pytest -v --make-reports doc_tests_gpu --doctest-modules $(cat doc_tests.txt) -sv --doctest-continue-on-failure --doctest-glob="*.md"
Comment on lines +46 to +52
Copy link
Collaborator Author

@ydshieh ydshieh Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the new get_all_doctest_files defined below


- name: Failure short reports
if: ${{ failure() }}
Expand Down
Loading