-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Added support for AzureOpenAiAgent in tools #23355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
Awesome that you are contributing. |
|
cc @sgugger |
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. This is exactly like the OpenAiAgent class execpt for two new arguments (is_chat_model is not useful since we can determine this from the model ID) so the arguments should just be added to OpenAiAgent as optionals.
|
Ah actually I see two arguments are renamed. Maybe have this be a subclass of |
|
DeploymentId is named arbitrarily and does not let you directly derive the model type from it unless you do additional requests to look it up. |
If it's easily doable, then yes let's aim for that! |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
Implements a new class AzureOpenAiAgent derived from Agent in transformer agents.
Fixes #23324
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.