Skip to content

Conversation

@alceballosa
Copy link
Contributor

What does this PR do?

Translates multiple_choice.mdx and question_answering.mdx into Spanish. Also updates the _toctree.yml file accordingly.

Fixes #15947

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?

@osanseviero @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 23, 2022

The documentation is not available anymore as the PR was closed or merged.

@osanseviero osanseviero self-requested a review October 24, 2022 09:25
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! @osanseviero feel free to merge if you're happy with this PR :-)

Copy link
Contributor

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, this is very cool and great translation!

@alceballosa
Copy link
Contributor Author

Thanks @osanseviero, I just updated all files to reflect your suggestions :)

@osanseviero
Copy link
Contributor

Thanks a lot! 🔥

@sgugger sgugger merged commit 371337a into huggingface:main Oct 25, 2022
@alceballosa alceballosa deleted the docs-spanish-question-answering-multiple-choice branch October 25, 2022 00:12
@alceballosa
Copy link
Contributor Author

@sgugger thanks for the merge! However, shouldn't the original issue (#15947) addressing the translations remain open? Think it was closed automatically bc I referenced it here.

@sgugger
Copy link
Collaborator

sgugger commented Oct 25, 2022

Yes, that's because you used the word "Fixes". You should have said something like "Related to ..." :-)

@alceballosa
Copy link
Contributor Author

Oops, sorry! Lesson learned :')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tranformers documentation translation to Spanish

4 participants