-
Notifications
You must be signed in to change notification settings - Fork 31.3k
Load sharded pt to flax #18419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ArthurZucker
merged 22 commits into
huggingface:main
from
ArthurZucker:convert_sharded_pt_to_flax
Aug 12, 2022
Merged
Load sharded pt to flax #18419
Changes from 18 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0a0d875
initial commit
ArthurZucker 4dcc32e
add small test
ArthurZucker 556fa9a
add cross pt tf flag to test
ArthurZucker 2e8b241
fix quality
ArthurZucker cfda646
style
ArthurZucker 4e49a48
update test with new repo
ArthurZucker 74a451b
fix failing test
ArthurZucker 708bcb6
update
ArthurZucker b9a9baf
Merge branch 'main' of https://github.com/huggingface/transformers in…
ArthurZucker c49bb18
fix wrong param ordering
ArthurZucker e20f971
style
ArthurZucker fdc54b6
Merge branch 'main' of https://github.com/huggingface/transformers in…
ArthurZucker 7495554
Merge branch 'huggingface:main' into convert_sharded_pt_to_flax
ArthurZucker 7f83b7d
Merge branch 'convert_sharded_pt_to_flax' of https://github.com/Arthu…
ArthurZucker 0e037a4
update based on review
ArthurZucker 4e5c03c
Merge branch 'main' of https://github.com/huggingface/transformers in…
ArthurZucker 2847af1
update related to recent new caching mechanism
ArthurZucker 55e8f7c
quality
ArthurZucker f871230
Update based on review
ArthurZucker b584707
quality and style
ArthurZucker 0957399
Update src/transformers/modeling_flax_utils.py
ArthurZucker a43af40
Merge branch 'main' of https://github.com/huggingface/transformers in…
ArthurZucker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should all go above, just after the part from flax sharded checkpoints. This part should only raise errors with a message to tell the user to use
from_pt=True.