[VisionTextDualEncoder] Add token_type_ids param #15073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yword argument 'token_type_ids'
patil-suraj
approved these changes
Jan 7, 2022
Contributor
patil-suraj
left a comment
patil-suraj
left a comment
There was a problem hiding this comment.
Good catch! Thank you for fixing this!
You are doing an awesome job with contributions, thanks a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This line will fail since there is
token_type_idsininputsbutget_text_featureshas no such param:transformers/src/transformers/models/vision_text_dual_encoder/modeling_vision_text_dual_encoder.py
Line 235 in ac224bb
Since
token_type_idsappears in other places inmodeling_vision_text_dual_encoder.py, I think it's reasonable to add it toget_text_features.Who can review?
@patil-suraj