support the trocr small models #14893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liminghao1630
force-pushed
the
trocr-small-models
branch
from
df7fa22 to
f94093e
Compare
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
NielsRogge
reviewed
Jan 6, 2022
Contributor
NielsRogge
left a comment
NielsRogge
left a comment
There was a problem hiding this comment.
Thanks for adding this!
Left some minor comments.
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
Co-authored-by: NielsRogge <[email protected]>
NielsRogge
reviewed
Jan 7, 2022
NielsRogge
reviewed
Jan 7, 2022
LysandreJik
approved these changes
Jan 10, 2022
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Thank you, @liminghao1630!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current TrOCRProcessor does not support the TrOCR small models, since the small models use the sentencepiece as the tokenizer, i.e. the XLMRobertaTokenizer. This PR modified the limitation of tokenizer in TrOCRProcessor and corresponding document.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@NielsRogge