Skip to content

Bump minimum Jax requirement to 2.8.0#10027

Merged
patrickvonplaten merged 2 commits into
masterfrom
bump_jax_version
Feb 5, 2021
Merged

Bump minimum Jax requirement to 2.8.0#10027
patrickvonplaten merged 2 commits into
masterfrom
bump_jax_version

Conversation

@patrickvonplaten
Copy link
Copy Markdown
Contributor

@patrickvonplaten patrickvonplaten commented Feb 5, 2021

What does this PR do?

According to jax-ml/jax#5374 this should fix #10017

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@patrickvonplaten patrickvonplaten linked an issue Feb 5, 2021 that may be closed by this pull request
@sgugger
Copy link
Copy Markdown
Collaborator

sgugger commented Feb 5, 2021

You need to run make style to update the table deps ;-)

@patrickvonplaten patrickvonplaten requested review from LysandreJik, sgugger and stas00 and removed request for LysandreJik February 5, 2021 12:50
Copy link
Copy Markdown
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickvonplaten patrickvonplaten merged commit b9720dd into master Feb 5, 2021
@patrickvonplaten patrickvonplaten deleted the bump_jax_version branch February 5, 2021 13:20
LysandreJik pushed a commit that referenced this pull request Feb 8, 2021
* Bump minimum Jax requirement to 2.8.0

* update table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python utils/check_repo.py fails

3 participants