🚀 Feature request
Motivation
Ticket created based on discussion lucidworks@46b17d2#commitcomment-44356945
The problem is when someone on a forked repository decides to sync up their masters with upstream (HF master) using a branch and a PR, all the PR and issue references on the upstream will make their way into the forked PR's commit history, if that user creates a merge commit.
Since GitHub autolinks issues and PRs on public forks, this will end up pinging the devs responsible for the referenced PRs creating unnecessary noise. The solution is to use a squashed merge.
One way to educate users with forked repos about this potential issue is to add instructions on how to do so to the CONTRIBUTING.md file.
Your contribution
A PR with instructions to avoid this situation will be up shortly.
cc @stas00
🚀 Feature request
Motivation
Ticket created based on discussion lucidworks@46b17d2#commitcomment-44356945
The problem is when someone on a forked repository decides to sync up their masters with upstream (HF master) using a branch and a PR, all the PR and issue references on the upstream will make their way into the forked PR's commit history, if that user creates a merge commit.
Since GitHub autolinks issues and PRs on public forks, this will end up pinging the devs responsible for the referenced PRs creating unnecessary noise. The solution is to use a squashed merge.
One way to educate users with forked repos about this potential issue is to add instructions on how to do so to the
CONTRIBUTING.mdfile.Your contribution
A PR with instructions to avoid this situation will be up shortly.
cc @stas00