Fix ApiBuilder in from_pretrained to use env variables

[vdebergue]

Bug

Using Tokenizer::from_pretrained does not download the tokenizer into the HF_HOME folder.
Instead it will download it in the user home cache directory.

Fix

Use env variable to load the ApiBuilder so it will read HF_HOME variable.
Currently they are ignored and the default cache location is used $HOME/.cache/huggingface

[ArthurZucker]

Not super familiar with API builder, if no evn var is defined I am guessing this is equivalent right? It won't just error out instead?

[vdebergue]

yes, without env it will fallback to the default and will be equivalent to ApiBuilder::new()

[ArthurZucker]

Suggested change

	let mut builder = ApiBuilder::from_env();
	let mut builder = ApiBuilder::from_env("HF_HOME");

should we not set that?

[vdebergue]

from_env does not take any parameter: https://github.com/huggingface/hf-hub/blob/main/src/api/sync.rs#L242 and the name of the env variables are already set in the code

[ArthurZucker]

Oh shit okay, I was looking at https://docs.rs/env_logger/latest/env_logger/struct.Builder.html#method.from_env, thanks for the heads up

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[ArthurZucker]

Can you run cargo clippy!

[ArthurZucker]

Sorry found #1737 which was opened sooner!

[vdebergue]

closing then, thanks !