CI: Install fbgemm package needed by torchao, update test #2887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer torchao versions require fbgemm-gpu-genai>=1.2.0. This PR installs it into the GPU Dockerfile used for nightly testing. I had initially hoped that this would also allow us to train int4_weight_only quantized torchao models, as explored in huggingface#2848. However, there is a new error when trying to use this. The test has been updated to reflect this.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
Note that the workflow for the test build of the Docker images failed: https://github.com/huggingface/peft/actions/runs/19033675634 However, this is not due to any change in this PR but rather seems to be caused by an error when trying to determine the list of changed files (JSON parsing error), so I'd say this PR is still good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer torchao versions require
fbgemm-gpu-genai>=1.2.0. This PR installs it into the GPU Dockerfile used for nightly testing.I had initially hoped that this would also allow us to train
int4_weight_onlyquantized torchao models, as explored in #2848. However, there is a new error when trying to use this. The test has been updated to reflect this.