[HybridAttention] Support past key values in attention_mask for stateful inference#1641
Open
apaniukov wants to merge 9 commits intohuggingface:mainfrom
Open
[HybridAttention] Support past key values in attention_mask for stateful inference#1641apaniukov wants to merge 9 commits intohuggingface:mainfrom
apaniukov wants to merge 9 commits intohuggingface:mainfrom
Conversation
…attention mask and generate appropriate dummy inputs
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
rkazants
reviewed
Mar 19, 2026
Collaborator
rkazants
left a comment
There was a problem hiding this comment.
can you please add test to reproduce this case?
Contributor
Author
Done. |
rkazants
reviewed
Mar 23, 2026
rkazants
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
GraniteMoeHybrid crashes with a shape mismatch error:
The RuntimeError at the Add node that combines the causal mask with the position-expanded attention_mask:
where seq_len != total_seq_len during 2nd+ generation steps when seq_len > 1 (e.g. second prefill stage).
The issue caused by patched
_update_causal_maskmethod. Hybrid models that doesn't patch it (Qwen3-Next and LFM2) work fine.Fix:
inputsproperty to use"past_sequence_length + sequence_length"forattention_maskfor-with-pastconversiontriuoperationFixes # (issue)
Before submitting