Skip to content

fix lazy_mode assignment #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
regisss merged 2 commits into from
Dec 6, 2024
Merged

fix lazy_mode assignment #1558

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dea5a2
fix lazy mode assignment
vidyasiv Dec 4, 2024
03601e9
Update trainer.py
yafshar Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion optimum/habana/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -986,7 +986,10 @@ def hpu_deepspeed_checkpointing(function, *checkpoint_args, use_reentrant: Optio
inputs["flash_attention_causal_mask"] = True
if self.model.config is not None:
if self.model.config.model_type in ["llama", "qwen2", "mistral", "starcoder2"]:
inputs["lazy_mode"] = args.use_lazy_mode
forward_method = getattr(self.model, "forward")
signature = inspect.signature(forward_method)
if "lazy_mode" in signature.parameters:
inputs["lazy_mode"] = args.use_lazy_mode
# TODO: keep syncs for fast DDP?
with self.accelerator.accumulate(model):
tr_loss_step = self.training_step(model, inputs)
Expand Down