Skip to content

Conversation

@baptistecolle
Copy link
Contributor

@baptistecolle baptistecolle commented Sep 17, 2024

AutoAWQ change its setup.py, this broke the building of our docker image

@baptistecolle baptistecolle marked this pull request as ready for review September 17, 2024 14:34
@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Sep 17, 2024

can you fix the same TORCH_VERSION issue in rocm image as well (we build the same packages there)

@baptistecolle
Copy link
Contributor Author

done, rocm is fixed

@IlyasMoutawwakil
Copy link
Member

IlyasMoutawwakil commented Sep 18, 2024

@baptistecolle baptistecolle marked this pull request as draft September 18, 2024 06:56
@baptistecolle baptistecolle changed the title fix broken cuda image fix broken docker images Sep 19, 2024
@baptistecolle baptistecolle changed the title fix broken docker images fix broken cuda and rocm images Sep 19, 2024
@baptistecolle baptistecolle marked this pull request as ready for review September 20, 2024 06:42
@baptistecolle
Copy link
Contributor Author

baptistecolle commented Sep 20, 2024

Now, everything concerning the broken Docker image due to an update with AutoAWQ should have been fixed.

There are still some failing tests in our pipeline at of today:
(because of #265 - issue with the codecarbon lock)

  • API CPU Tests / run_api_cpu_tests (pull_request)
  • API CUDA Tests / run_api_cuda_tests (pull_request)
    (issue with the use of the deprecated method - is_torch_tpu_available Fix is_torch_tpu_available in ORT Trainer optimum#2028, so we need to wait for next release of optimum for the fix)
  • CLI CUDA Torch-ORT Multi-GPU Tests / run_cli_cuda_torch_ort_multi_gpu_tests
  • CLI CUDA Torch-ORT Single-GPU Tests / run_cli_cuda_torch_ort_single_gpu_tests

@baptistecolle baptistecolle marked this pull request as draft September 20, 2024 08:05
baptistecolle and others added 3 commits September 20, 2024 10:31
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Co-authored-by: Ilyas Moutawwakil <[email protected]>
Co-authored-by: Ilyas Moutawwakil <[email protected]>
@IlyasMoutawwakil IlyasMoutawwakil marked this pull request as ready for review September 20, 2024 09:52
@IlyasMoutawwakil IlyasMoutawwakil merged commit 39ca491 into main Sep 20, 2024
@IlyasMoutawwakil IlyasMoutawwakil deleted the fix-autoawq-install branch August 19, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants