-
Notifications
You must be signed in to change notification settings - Fork 854
Xet Upload with byte array #3035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for byte arrays @bpronan ! I've left a few comments mostly related to Python syntax. All good otherwise
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
Co-authored-by: Lucain <[email protected]>
hanouticelina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! thanks @bpronan for the PR
Wauplin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! Let's ship this! :)
With a new feature in xet-core, we now support specifying a byte array as upload data for a xet file upload. We are leveraging that to provide support for specifying an array of
bytesin thepath_or_fileobjparameter to the file upload methods.The xet-core change comes with some updates to the
hf_xetinterface. Notably, the notion of a "pointer file" has been removed from the library entirely. During the next major version release of hf_xet, we will be removing thePyPointerFileentirely. This python library PR includes moving on to the new data structures, but we've added a test here to ensure backwards compatibility remains until then.Note: the xet tests here are run against all PRs in the xet-core library.
This should allow us to address the dataset viewer issue here (cc: @lhoestq).