-
Notifications
You must be signed in to change notification settings - Fork 854
Use uv in CI to speed-up requirements install #2072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4983ab4
Use uv in CI to speed-up requirements install
Wauplin b22aa37
fix commands
Wauplin f566a00
run in venv
Wauplin 000a18b
echo
Wauplin 2f88d94
try something else
Wauplin 038d0e3
hack
Wauplin 2a9e61d
better?
Wauplin 8b8e9ac
remove pip freeze
Wauplin 1d9edc7
fix
Wauplin 1547e68
better
Wauplin eda73a5
fixed
Wauplin ab7e051
comments
Wauplin 209a9ec
windows
Wauplin cfce875
Merge branch 'mait n' into use-uv-in-ci
Wauplin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to do
uv pip install --system "huggingface_hub[dev] @ ."on the latest release, if you want to remove the virtualenv (per the PR summary), but using a virtualenv is also good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @charliermarsh! I just saw the issue has been merged on uv's repo 🎉. Thanks for the direct ping here ❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! It's pretty new so of course ping if you see issues with it.