Skip to content

Added/Changed/Depreacted directives #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2022
Merged

Added/Changed/Depreacted directives #233

merged 2 commits into from
May 31, 2022

Conversation

@mishig25
Copy link
Contributor

@mishig25 mishig25 commented May 31, 2022 •
edited
Loading

Implemented directives for: Added, Changed, Deprecated

Related to #173

In the screenshots, please find proposed syntax & results (UIs) wdyt?

Screenshot 2022-05-31 at 11 05 54

Screenshot 2022-05-31 at 11 05 45

Screenshot 2022-05-31 at 11 05 38

  • todo: add imports

sgugger
sgugger approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!
I think we should import those new components here though, no?

@mishig25
Copy link
Contributor Author

mishig25 commented May 31, 2022

indeed, added the imports & merging it

@mishig25 mishig25 merged commit 196b834 into main May 31, 2022
@mishig25 mishig25 deleted the version_directives branch May 31, 2022 13:54
@albertvillanova
Copy link
Member

albertvillanova commented May 31, 2022

Thanks @mishig25.

I'm testing it.

@albertvillanova albertvillanova mentioned this pull request May 31, 2022
Merged
@albertvillanova
Copy link
Member

albertvillanova commented Jun 3, 2022

Issue reported:

No special formatting appears:

@mishig25 mishig25 mentioned this pull request Jun 6, 2022
Merged
@albertvillanova albertvillanova mentioned this pull request Jul 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LysandreJik LysandreJik Awaiting requested review from LysandreJik

@albertvillanova albertvillanova Awaiting requested review from albertvillanova

@gary149 gary149 Awaiting requested review from gary149

@adrinjalali adrinjalali Awaiting requested review from adrinjalali

1 more reviewer

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mishig25 @albertvillanova @sgugger