-
Notifications
You must be signed in to change notification settings - Fork 755
Fix: mlagents-learn: command not found
#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: mlagents-learn: command not found
#587
Conversation
mlagents-learn command not found issuemlagents-learn: command not found issue
mlagents-learn: command not found issuemlagents-learn: command not found
|
@simoninithomas Gentle Bump For Review!! |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
|
||
| ## Setup the Virtual Environment 🔽 | ||
|
|
||
| - In order for the **ML-Agents** to run successfully in Colab, Colab's Python version must meet the library's Python requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this part, but I think we can also add it to the notebook since most of students will directly jump in the notebook 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback @simoninithomas 🤗! The PR already includes the Setup the Virtual Environment section right after the Clone The Repository section in the notebooks as well, and the same section has been added in the corresponding .mdx files like linked above.
This is done for both the Bonus-Unit-1 and Unit-5 notebooks and their corresponding .mdx files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks. It's ready to merge. Thanks for your work 🔥
simoninithomas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for your work 🤗
Fixes #586
This PR fixes the Python version incompatibility between Colab and the ML-Agents library, which caused installation to silently fail and commands like
mlagents-learnto not be recognized. It provides a fix by setting up a compatible Python version using a venv managed with Miniconda.units\en.mdxfiles to align with the changes.@simoninithomas Gentle ping for review.
Let me know if any other changes are needed. Thanks! 🤗