Skip to content

Better streaming retries (504 and 429) #7847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Better streaming retries (504 and 429) #7847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/datasets/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,8 @@
# Streaming
STREAMING_READ_MAX_RETRIES = 20
STREAMING_READ_RETRY_INTERVAL = 5
STREAMING_READ_SERVER_UNAVAILABLE_RETRY_INTERVAL = 20
STREAMING_READ_RATE_LIMIT_RETRY_INTERVAL = 60
STREAMING_OPEN_MAX_RETRIES = 20
STREAMING_OPEN_RETRY_INTERVAL = 5

Expand Down
18 changes: 18 additions & 0 deletions src/datasets/utils/file_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ class _AiohttpClientError(Exception):
requests.exceptions.Timeout,
httpx.RequestError,
)
SERVER_UNAVAILABLE_CODE = 504
RATE_LIMIT_CODE = 429


def is_remote_url(url_or_filename: str) -> bool:
Expand Down Expand Up @@ -827,6 +829,22 @@ def read_with_retries(*args, **kwargs):
f"Got disconnected from remote data host. Retrying in {config.STREAMING_READ_RETRY_INTERVAL}sec [{retry}/{max_retries}]"
)
time.sleep(config.STREAMING_READ_RETRY_INTERVAL)
except huggingface_hub.errors.HfHubHTTPError as err:
if err.response is not None and err.response.status_code == SERVER_UNAVAILABLE_CODE:
disconnect_err = err
logger.warning(
f"Got disconnected from remote data host. Retrying in {config.STREAMING_READ_SERVER_UNAVAILABLE_RETRY_INTERVAL}sec [{retry}/{max_retries}]"
)
time.sleep(config.STREAMING_READ_SERVER_UNAVAILABLE_RETRY_INTERVAL)
elif err.response is not None and err.response.status_code == RATE_LIMIT_CODE:
disconnect_err = err
logger.warning(str(err))
logger.warning(
f"Got disconnected from remote data host. Retrying in {config.STREAMING_READ_RATE_LIMIT_RETRY_INTERVAL}sec [{retry}/{max_retries}]"
)
time.sleep(config.STREAMING_READ_RATE_LIMIT_RETRY_INTERVAL)
else:
raise
else:
raise ConnectionError("Server Disconnected") from disconnect_err
return out
Expand Down
Loading