Skip to content

Add missing property on RepeatExamplesIterable #7581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

Add missing property on RepeatExamplesIterable #7581

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ec79a8
Add missing property
SilvanCodes May 22, 2025
9f42abd
Fix shard_data_sources for RepeatExamplesIterable
SilvanCodes May 22, 2025
0a4549a
Update src/datasets/iterable_dataset.py
lhoestq Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/datasets/iterable_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1674,16 +1674,16 @@ def shuffle_data_sources(self, generator: np.random.Generator) -> "RepeatExample
"""Shuffle the underlying iterable, then repeat."""
return RepeatExamplesIterable(self.ex_iterable.shuffle_data_sources(generator), num_times=self.num_times)

def shard_data_sources(self, worker_id: int, num_workers: int) -> "RepeatExamplesIterable":
def shard_data_sources(self, num_shards: int, index: int, contiguous=True) -> "RepeatExamplesIterable":
"""Shard, then repeat shards."""
return RepeatExamplesIterable(
self.ex_iterable.shard_data_sources(worker_id, num_workers),
self.ex_iterable.shard_data_sources(num_shards, index, contiguous=contiguous),
num_times=self.num_times,
)

@property
def n_shards(self) -> int:
return self.ex_iterable.n_shards
def num_shards(self) -> int:
return self.ex_iterable.num_shards


class TakeExamplesIterable(_BaseExamplesIterable):
Expand Down