Skip to content

Fix incorrect rank value in data splitting #6994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Fix incorrect rank value in data splitting #6994

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
490dccb
Fix incorrect rank value in data splitting (#6990)
yzhangcs Jun 24, 2024
fda1135
Add tests for splitting distributed datasets
yzhangcs Jun 25, 2024
b8c0232
Merge branch 'main' into main
yzhangcs Jun 25, 2024
02420b8
make style
lhoestq Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasets/iterable_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2940,8 +2940,8 @@ def _split_by_node_iterable_dataset(dataset: IterableDataset, rank: int, world_s
[`IterableDataset`]: The iterable dataset to be used on the node at rank `rank`.
"""
if dataset._distributed:
world_size = world_size * dataset._distributed.world_size
rank = world_size * dataset._distributed.rank + rank
world_size = world_size * dataset._distributed.world_size
distributed = DistributedConfig(rank=rank, world_size=world_size)
return IterableDataset(
ex_iterable=dataset._ex_iterable,
Expand Down