Skip to content

Fix dataset name for community Hub script-datasets #6855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 3, 2024
Merged

Fix dataset name for community Hub script-datasets #6855

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4b25626
Pass dataset_name to HubDatasetModuleFactoryWithScript
albertvillanova May 2, 2024
9f80783
Merge remote-tracking branch 'upstream/main' into fix-6854
albertvillanova May 2, 2024
575153a
Update test
albertvillanova May 2, 2024
f864b24
Revert changes
albertvillanova May 2, 2024
e794995
Use repo_id if set instead of dataset_name
albertvillanova May 2, 2024
3aa4949
Refactor
albertvillanova May 2, 2024
08b5348
Fix other usage examples
albertvillanova May 2, 2024
5992789
Merge remote-tracking branch 'upstream/main' into fix-6854
albertvillanova May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/datasets/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,9 @@ def _create_builder_config(
else:
if len(self.BUILDER_CONFIGS) > 1:
if not config_kwargs:
example_of_usage = f"load_dataset('{self.dataset_name}', '{self.BUILDER_CONFIGS[0].name}')"
example_of_usage = (
f"load_dataset('{self.repo_id or self.dataset_name}', '{self.BUILDER_CONFIGS[0].name}')"
)
raise ValueError(
"Config name is missing."
f"\nPlease pick one among the available configs: {list(self.builder_configs.keys())}"
Expand Down Expand Up @@ -1054,7 +1056,7 @@ def _check_manual_download(self, dl_manager):
Please follow the manual download instructions:
{self.manual_download_instructions}
Manual data can be loaded with:
datasets.load_dataset("{self.dataset_name}", data_dir="<path/to/manual/data>")"""
datasets.load_dataset("{self.repo_id or self.dataset_name}", data_dir="<path/to/manual/data>")"""
)
)

Expand Down Expand Up @@ -2116,7 +2118,7 @@ def _download_and_prepare(self, dl_manager, verification_mode, **prepare_splits_
beam_options = self._beam_options

if not beam_runner and not beam_options:
usage_example = f"load_dataset('{self.name}', '{self.config.name}', beam_runner='DirectRunner')"
usage_example = f"load_dataset('{self.repo_id or self.dataset_name}', '{self.config.name}', beam_runner='DirectRunner')"
raise MissingBeamOptions(
"Trying to generate a dataset using Apache Beam, yet no Beam Runner "
"or PipelineOptions() has been provided in `load_dataset` or in the "
Expand Down