Support PathLike input in save_to_disk / load_from_disk #6828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
albertvillanova
approved these changes
Apr 23, 2024
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks you.
Do you think it would be worth adding a test?
| Args: | ||
| dataset_path (`str`): | ||
| dataset_path (`PathLike`): |
Member
There was a problem hiding this comment.
Great, so now this is aligned with the type hint: dataset_path: PathLike
Member
Author
There was a problem hiding this comment.
yes we should have one imo before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.