Skip to content

Minor fix in iter_files for hidden files #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Minor fix in iter_files for hidden files #6092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasets/download/download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def _iter_from_paths(cls, urlpaths: Union[str, List[str]]) -> Generator[str, Non
if os.path.isfile(urlpath):
if os.path.basename(urlpath).startswith((".", "__")):
# skipping hidden files
return
continue
yield urlpath
else:
for dirpath, dirnames, filenames in os.walk(urlpath):
Expand Down
2 changes: 1 addition & 1 deletion src/datasets/download/streaming_download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,7 +916,7 @@ def _iter_from_urlpaths(
if xisfile(urlpath, download_config=download_config):
if xbasename(urlpath).startswith((".", "__")):
# skipping hidden files
return
continue
yield urlpath
elif xisdir(urlpath, download_config=download_config):
for dirpath, dirnames, filenames in xwalk(urlpath, download_config=download_config):
Expand Down