Skip to content

fix tqdm lock deletion #6068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix tqdm lock deletion #6068

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03750f4
fix tqdm lock deletion
lhoestq Jul 25, 2023
cb0b324
comment
lhoestq Jul 25, 2023
32e4df8
style
lhoestq Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/datasets/utils/logging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,8 +202,6 @@ def __exit__(self, type_, value, traceback):


class _tqdm_cls:
_lock = None
Copy link
Member Author

@lhoestq lhoestq Jul 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it reverts #6067


def __call__(self, *args, disable=False, **kwargs):
if _tqdm_active and not disable:
return tqdm_lib.tqdm(*args, **kwargs)
Expand All @@ -219,6 +217,14 @@ def get_lock(self):
if _tqdm_active:
return tqdm_lib.tqdm.get_lock()

def __delattr__(self, attr):
"""fix for https://github.com/huggingface/datasets/issues/6066"""
try:
del self.__dict__[attr]
except KeyError:
if attr != "_lock":
raise AttributeError(attr)


tqdm = _tqdm_cls()

Expand Down