Skip to content

Do not sort splits in dataset info #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Do not sort splits in dataset info #5201

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
aaf73c4
do not sort splits in splits info
Nov 4, 2022
fe51b19
sort splits in tests
Nov 4, 2022
1742bae
remove comment
Nov 4, 2022
a063c6f
Revert "sort splits in tests"
Nov 4, 2022
b090c3a
Merge branch 'huggingface:main' into do-not-sort-splits-fix-ci
Nov 4, 2022
6e10c33
return list in sliced split info
Nov 4, 2022
fe57ad1
Merge branch 'huggingface:main' into do-not-sort-splits-fix-ci
Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/datasets/splits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,7 @@ def __getitem__(self, slice_value):
return split_instruction

def get_list_sliced_split_info(self):
return list(sorted(self._splits.values(), key=lambda x: x.split_info.name))
return list(self._splits.values())


class SplitDict(dict):
Expand Down Expand Up @@ -567,9 +567,8 @@ def from_split_dict(cls, split_infos: Union[List, Dict], dataset_name: Optional[

def to_split_dict(self):
"""Returns a list of SplitInfo protos that we have."""
# Return the SplitInfo, sorted by name
out = []
for split_name, split_info in sorted(self.items()):
for split_name, split_info in self.items():
split_info = copy.deepcopy(split_info)
split_info.name = split_name
out.append(split_info)
Expand Down