Fix class name of symbolic link

[riccardobucco]

Fix #5098

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

[albertvillanova]

I have removed the reference to the Issue in the PR title, so that we avoid to have both references (to the issue and to the PR) in the merge commit to the main branch.

Instead, it should be commented in the PR description, so that the PR is appropriately linked by GitHub to its corresponding Issue:

Fix #5098.

[albertvillanova]

Thanks for the fix, @riccardobucco.

Could you please implement a regression test as well? This is considered a good practice in software development.

[riccardobucco]

@albertvillanova What should I test in your opinion? Also, where should I save the test file and how should I name it? Thanks for your support

[albertvillanova]

The regression test to be implemented should test what your PR fixes: that is, that _resolve_single_pattern_locally function does not resolve any symbolic link when passed a directory that does contain any.

As you are testing a function in data_files.py, the corresponding test should be in tests/test_data_files.py.

You could name the test something lilke: test_resolve_single_pattern_locally_does_not_resolve_symbolic_links

You could take inspiration from other tests there in that file.

[albertvillanova]

Thanks @riccardobucco for having tried, and thanks @mariosasko for the proposal of the fix solution (#5098 (comment)) and the addition of the regression test (d5f135a).