patch CI_HUB_TOKEN_PATH with Path instead of str #5026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
approved these changes
Sep 26, 2022
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Good catch thanks ! Sorry I didn't spot it ;)
|
The documentation is not available anymore as the PR was closed or merged. |
lhoestq
pushed a commit
that referenced
this pull request
Oct 5, 2022
* patch CI_HUB_TOKEN_PATH with Path instead of str * flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the tests for
huggingface_hub==0.10.0rc0prerelease (see failed CI).Related to this thread (internal link).
Note: this should be a backward compatible fix (e.g. works also with previous versions of
huggingface_hub)I am not sure where to put the changes so feel free to cherry-pick the commit and close this one without merging.
cc @lhoestq