Skip to content

Conversation

@mariosasko
Copy link
Collaborator

@mariosasko mariosasko requested a review from lhoestq September 13, 2022 16:19
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 13, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mariosasko mariosasko merged commit 418b3bc into main Sep 13, 2022
@mariosasko mariosasko deleted the map-streaming-fn-kwargs branch September 13, 2022 16:45
@brianhill11
Copy link

Thank you for adding this fix!

Would it be possible to get fn_kwargs added to IterableDatasetDict.map as well? It looks like a very similar problem, and hopefully shouldn't be a huge change.

@mariosasko
Copy link
Collaborator Author

Hi @brianhill11! #5810 adds this (opened a couple of days ago). It should be merged soon.

@brianhill11
Copy link

That's fantastic news, thanks @mariosasko ! I'll give it a shot once the changes are merged in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants