Add Dataset.from_generator
#4957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I restarted the builder PR job just in case |
|
The documentation is not available anymore as the PR was closed or merged. |
Collaborator
Author
|
CI is now green. huggingface/doc-builder#296 explains why it failed. |
lhoestq
approved these changes
Sep 15, 2022
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Awesome thank you !
Maybe let's open an issue to also add IterableDataset.from_generator ?
Co-authored-by: Quentin Lhoest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Dataset.from_generatorto the API to allow creating datasets from data larger than RAM. The implementation relies on a packaged module not exposed inload_datasetto tie this method withdatasets' caching mechanism.Closes #4417